⚡ Bolt: Optimize decodeAddr in proc/net to eliminate allocations#188
⚡ Bolt: Optimize decodeAddr in proc/net to eliminate allocations#188blue4209211 wants to merge 1 commit into
Conversation
- Replaced `make` with stack arrays - Used `netaddr` constructors to avoid `net.IP` - Zero allocations per call Co-authored-by: blue4209211 <3078106+blue4209211@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
2 participants
💡 What:
Refactored
decodeAddrinproc/net.goto use stack-allocated arrays ([16]byteand[2]byte) instead of heap allocations (make([]byte, ...)).Replaced
net.IP(slice) usage withinet.af/netaddrdirect construction (netaddr.IPv4andnetaddr.IPFrom16).🎯 Why:
decodeAddris called for every socket in/proc/net/tcpand/proc/net/tcp6.The previous implementation allocated 2 slices per address (IP and Port) plus
net.IPoverhead.For systems with many connections, this adds up to significant GC pressure.
📊 Impact:
🔬 Measurement:
Correctness verified with
go test -v ./proc/...(specificallyTestGetSockets).PR created automatically by Jules for task 9187328519729303304 started by @blue4209211